Skip to content

Use env config for db

Nyan Helsing requested to merge NyanHelsing/firefish:ft/use-env-for-dburls into develop

#10877

Baking sicrets into a docker image is a bad practice since it can make it easier to leak them.

The current solution for docker doesn't work since infrastructure platforms dont have a disk to mount their config from into the container like the docker-compose example provides. The pattern used here is to pass secrets into a container as it starts up.

This PR adds in the ability to pass secrets for postgres and redis through env variables so that the images don't need to contain secrets and platforms can pass secrets into the running container when it is launched.

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request
  • I have made sure to run pnpm run format before submitting this pull request

If this merge request makes changes to the Firefish API, please update docs/api-change.md

  • I updated the document / This merge request doesn't include API changes
Edited by Nyan Helsing

Merge request reports