fix: Use "iconClass" instead of "icon" in MkDialog; remove "null" in input field
What does this PR do?
- A recent refactor resulted in the
icon
import being renamed toiconClass
, but usages of this had not been renamed to match, which caused the "Filter" menu in the "Search" dialog to fail to open. - If an item was picked from the "Filter" menu before any text had been entered in the box, the input value would be prepended with a literal
null
due to its null value being stringified. This prevents that from happening and also trims spaces around the input values to make them look prettier. - This also cleans up a couple of typescript errors I noticed while working in
MkDialog.vue
.
Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines
-
I agree to follow this project's Contribution Guidelines -
I have made sure to test this pull request -
I have made sure to run pnpm run format
before submitting this pull request -
This merge request doesn't include API changes
Edited by Minneyar